The following document contains the results of Checkstyle 7.2 with sun_checks.xml ruleset.
Category | Rule | Violations | Severity |
---|---|---|---|
blocks | LeftCurly | 1 | ![]() |
coding | HiddenField | 12 | ![]() |
MagicNumber | 3 | ![]() | |
SimplifyBooleanExpression | 1 | ![]() | |
design | DesignForExtension | 25 | ![]() |
VisibilityModifier | 7 | ![]() | |
javadoc | JavadocMethod | 29 | ![]() |
JavadocPackage | 2 | ![]() | |
JavadocType | 2 | ![]() | |
JavadocVariable | 19 | ![]() | |
misc | FinalParameters | 34 | ![]() |
modifier | ModifierOrder | 3 | ![]() |
regexp | RegexpSingleline
|
4 | ![]() |
sizes | LineLength | 22 | ![]() |
whitespace | ParenPad | 4 | ![]() |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
javadoc | JavadocPackage | Missing package-info.java file. | |
![]() |
javadoc | JavadocType | Missing a Javadoc comment. | 19 |
![]() |
blocks | LeftCurly | '{' at column 1 should be on the previous line. | 26 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 28 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 31 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 85). | 35 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 38 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 49 |
![]() |
misc | FinalParameters | Parameter userName should be final. | 55 |
![]() |
coding | HiddenField | 'userName' hides a field. | 55 |
![]() |
design | DesignForExtension | Class 'GMailConfiguration' looks like designed for extension (can be subclassed), but the method 'withUserName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GMailConfiguration' final or making the method 'withUserName' static/final/abstract/empty, or adding allowed annotation for the method. | 59 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 59 |
![]() |
misc | FinalParameters | Parameter userName should be final. | 59 |
![]() |
coding | HiddenField | 'userName' hides a field. | 59 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 65 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 76 |
![]() |
misc | FinalParameters | Parameter password should be final. | 82 |
![]() |
coding | HiddenField | 'password' hides a field. | 82 |
![]() |
design | DesignForExtension | Class 'GMailConfiguration' looks like designed for extension (can be subclassed), but the method 'withPassword' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GMailConfiguration' final or making the method 'withPassword' static/final/abstract/empty, or adding allowed annotation for the method. | 86 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 86 |
![]() |
misc | FinalParameters | Parameter password should be final. | 86 |
![]() |
coding | HiddenField | 'password' hides a field. | 86 |
![]() |
design | DesignForExtension | Class 'GMailConfiguration' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GMailConfiguration' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 91 |
![]() |
design | DesignForExtension | Class 'GMailConfiguration' looks like designed for extension (can be subclassed), but the method 'getAdditionalProperties' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GMailConfiguration' final or making the method 'getAdditionalProperties' static/final/abstract/empty, or adding allowed annotation for the method. | 96 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 96 |
![]() |
design | DesignForExtension | Class 'GMailConfiguration' looks like designed for extension (can be subclassed), but the method 'setAdditionalProperty' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GMailConfiguration' final or making the method 'setAdditionalProperty' static/final/abstract/empty, or adding allowed annotation for the method. | 102 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 102 |
![]() |
misc | FinalParameters | Parameter name should be final. | 104 |
![]() |
misc | FinalParameters | Parameter value should be final. | 104 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 81). | 108 |
![]() |
design | DesignForExtension | Class 'GMailConfiguration' looks like designed for extension (can be subclassed), but the method 'withAdditionalProperty' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GMailConfiguration' final or making the method 'withAdditionalProperty' static/final/abstract/empty, or adding allowed annotation for the method. | 108 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 108 |
![]() |
misc | FinalParameters | Parameter name should be final. | 108 |
![]() |
misc | FinalParameters | Parameter value should be final. | 108 |
![]() |
design | DesignForExtension | Class 'GMailConfiguration' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GMailConfiguration' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 113 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 113). | 115 |
![]() |
design | DesignForExtension | Class 'GMailConfiguration' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GMailConfiguration' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 118 |
![]() |
misc | FinalParameters | Parameter other should be final. | 119 |
![]() |
coding | SimplifyBooleanExpression | Expression can be simplified. | 123 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 163). | 127 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
javadoc | JavadocPackage | Missing package-info.java file. | |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 92). | 36 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 36 |
![]() |
modifier | ModifierOrder | 'static' modifier out of order with the JLS suggestions. | 36 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 40 |
![]() |
misc | FinalParameters | Parameter provider should be final. | 40 |
![]() |
coding | HiddenField | 'provider' hides a field. | 40 |
![]() |
design | DesignForExtension | Class 'GMailImapProviderTask' looks like designed for extension (can be subclassed), but the method 'run' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GMailImapProviderTask' final or making the method 'run' static/final/abstract/empty, or adding allowed annotation for the method. | 44 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 85). | 47 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 102). | 52 |
![]() |
whitespace | ParenPad | '(' is followed by whitespace. | 52 |
![]() |
whitespace | ParenPad | ')' is preceded with whitespace. | 52 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
sizes | LineLength | Line is longer than 80 characters (found 89). | 57 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 101). | 59 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 59 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 61 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 63 |
![]() |
misc | FinalParameters | Parameter provider should be final. | 63 |
![]() |
coding | HiddenField | 'provider' hides a field. | 63 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 78 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 81 |
![]() |
misc | FinalParameters | Parameter event should be final. | 81 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 85 |
![]() |
misc | FinalParameters | Parameter event should be final. | 85 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 89 |
![]() |
misc | FinalParameters | Parameter event should be final. | 89 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 95 |
![]() |
misc | FinalParameters | Parameter event should be final. | 95 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 99 |
![]() |
misc | FinalParameters | Parameter event should be final. | 99 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 86). | 103 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 103 |
![]() |
misc | FinalParameters | Parameter activity should be final. | 103 |
![]() |
misc | FinalParameters | Parameter gmailMessage should be final. | 103 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 92). | 104 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 108 |
![]() |
misc | FinalParameters | Parameter idparts should be final. | 108 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 123). | 110 |
![]() |
design | DesignForExtension | Class 'GMailMessageActivitySerializer' looks like designed for extension (can be subclassed), but the method 'serializationFormat' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GMailMessageActivitySerializer' final or making the method 'serializationFormat' static/final/abstract/empty, or adding allowed annotation for the method. | 113 |
![]() |
design | DesignForExtension | Class 'GMailMessageActivitySerializer' looks like designed for extension (can be subclassed), but the method 'serialize' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GMailMessageActivitySerializer' final or making the method 'serialize' static/final/abstract/empty, or adding allowed annotation for the method. | 118 |
![]() |
misc | FinalParameters | Parameter activity should be final. | 119 |
![]() |
design | DesignForExtension | Class 'GMailMessageActivitySerializer' looks like designed for extension (can be subclassed), but the method 'deserialize' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GMailMessageActivitySerializer' final or making the method 'deserialize' static/final/abstract/empty, or adding allowed annotation for the method. | 123 |
![]() |
misc | FinalParameters | Parameter gmailMessage should be final. | 124 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 119). | 127 |
![]() |
coding | HiddenField | 'provider' hides a field. | 129 |
![]() |
design | DesignForExtension | Class 'GMailMessageActivitySerializer' looks like designed for extension (can be subclassed), but the method 'deserializeAll' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GMailMessageActivitySerializer' final or making the method 'deserializeAll' static/final/abstract/empty, or adding allowed annotation for the method. | 155 |
![]() |
misc | FinalParameters | Parameter serializedList should be final. | 156 |
![]() |
design | DesignForExtension | Class 'GMailMessageActivitySerializer' looks like designed for extension (can be subclassed), but the method 'convert' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GMailMessageActivitySerializer' final or making the method 'convert' static/final/abstract/empty, or adding allowed annotation for the method. | 160 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 160 |
![]() |
misc | FinalParameters | Parameter event should be final. | 160 |
![]() |
javadoc | JavadocType | Missing a Javadoc comment. | 164 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 165 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 169 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 173 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 181 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 186 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 58 |
![]() |
modifier | ModifierOrder | 'static' modifier out of order with the JLS suggestions. | 58 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 84). | 60 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 60 |
![]() |
modifier | ModifierOrder | 'static' modifier out of order with the JLS suggestions. | 60 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 61 |
![]() |
design | VisibilityModifier | Variable 'inQueue' must be private and have accessor methods. | 61 |
![]() |
coding | MagicNumber | '10000' is a magic number. | 61 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 87). | 62 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 62 |
![]() |
design | VisibilityModifier | Variable 'providerQueue' must be private and have accessor methods. | 62 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 63 |
![]() |
design | VisibilityModifier | Variable 'task' must be private and have accessor methods. | 63 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 64 |
![]() |
design | VisibilityModifier | Variable 'rssClient' must be private and have accessor methods. | 64 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 65 |
![]() |
design | VisibilityModifier | Variable 'imapClient' must be private and have accessor methods. | 65 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 66 |
![]() |
design | VisibilityModifier | Variable 'countersTotal' must be private and have accessor methods. | 66 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 67 |
![]() |
design | VisibilityModifier | Variable 'countersCurrent' must be private and have accessor methods. | 67 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 68 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 69 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 70 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 72 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 81). | 74 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 77 |
![]() |
misc | FinalParameters | Parameter config should be final. | 77 |
![]() |
coding | HiddenField | 'config' hides a field. | 77 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 81 |
![]() |
misc | FinalParameters | Parameter klass should be final. | 81 |
![]() |
coding | HiddenField | 'klass' hides a field. | 81 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 81). | 83 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 87 |
![]() |
misc | FinalParameters | Parameter config should be final. | 87 |
![]() |
coding | HiddenField | 'config' hides a field. | 87 |
![]() |
misc | FinalParameters | Parameter klass should be final. | 87 |
![]() |
coding | HiddenField | 'klass' hides a field. | 87 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 95). | 92 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 92 |
![]() |
misc | FinalParameters | Parameter nThreads should be final. | 92 |
![]() |
misc | FinalParameters | Parameter queueSize should be final. | 92 |
![]() |
coding | MagicNumber | '5000L' is a magic number. | 94 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 94). | 95 |
![]() |
design | DesignForExtension | Class 'GMailProvider' looks like designed for extension (can be subclassed), but the method 'getConfig' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GMailProvider' final or making the method 'getConfig' static/final/abstract/empty, or adding allowed annotation for the method. | 98 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 98 |
![]() |
design | DesignForExtension | Class 'GMailProvider' looks like designed for extension (can be subclassed), but the method 'setConfig' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GMailProvider' final or making the method 'setConfig' static/final/abstract/empty, or adding allowed annotation for the method. | 102 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 102 |
![]() |
misc | FinalParameters | Parameter config should be final. | 102 |
![]() |
coding | HiddenField | 'config' hides a field. | 102 |
![]() |
design | DesignForExtension | Class 'GMailProvider' looks like designed for extension (can be subclassed), but the method 'getInQueue' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GMailProvider' final or making the method 'getInQueue' static/final/abstract/empty, or adding allowed annotation for the method. | 106 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 106 |
![]() |
design | DesignForExtension | Class 'GMailProvider' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GMailProvider' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 110 |
![]() |
design | DesignForExtension | Class 'GMailProvider' looks like designed for extension (can be subclassed), but the method 'startStream' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GMailProvider' final or making the method 'startStream' static/final/abstract/empty, or adding allowed annotation for the method. | 115 |
![]() |
design | DesignForExtension | Class 'GMailProvider' looks like designed for extension (can be subclassed), but the method 'readCurrent' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GMailProvider' final or making the method 'readCurrent' static/final/abstract/empty, or adding allowed annotation for the method. | 122 |
![]() |
whitespace | ParenPad | '(' is followed by whitespace. | 127 |
![]() |
whitespace | ParenPad | ')' is preceded with whitespace. | 127 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 81). | 128 |
![]() |
design | DesignForExtension | Class 'GMailProvider' looks like designed for extension (can be subclassed), but the method 'readNew' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GMailProvider' final or making the method 'readNew' static/final/abstract/empty, or adding allowed annotation for the method. | 139 |
![]() |
misc | FinalParameters | Parameter sequence should be final. | 140 |
![]() |
design | DesignForExtension | Class 'GMailProvider' looks like designed for extension (can be subclassed), but the method 'readRange' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GMailProvider' final or making the method 'readRange' static/final/abstract/empty, or adding allowed annotation for the method. | 144 |
![]() |
misc | FinalParameters | Parameter start should be final. | 145 |
![]() |
misc | FinalParameters | Parameter end should be final. | 145 |
![]() |
design | DesignForExtension | Class 'GMailProvider' looks like designed for extension (can be subclassed), but the method 'isRunning' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GMailProvider' final or making the method 'isRunning' static/final/abstract/empty, or adding allowed annotation for the method. | 149 |
![]() |
design | DesignForExtension | Class 'GMailProvider' looks like designed for extension (can be subclassed), but the method 'prepare' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GMailProvider' final or making the method 'prepare' static/final/abstract/empty, or adding allowed annotation for the method. | 154 |
![]() |
misc | FinalParameters | Parameter configurationObject should be final. | 155 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 118). | 162 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 97). | 167 |
![]() |
design | DesignForExtension | Class 'GMailProvider' looks like designed for extension (can be subclassed), but the method 'cleanUp' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GMailProvider' final or making the method 'cleanUp' static/final/abstract/empty, or adding allowed annotation for the method. | 175 |
![]() |
coding | MagicNumber | '5' is a magic number. | 178 |